linux-kernel - Re: [PATCH v1 1/3] selftests/mm: factor out detection of hugetlb page sizes into vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4dfd0f47-e1f7-1e9f-65e0-ee4881495be3@redhat.com>
Date:   Thu, 1 Jun 2023 09:52:01 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Lorenzo Stoakes <lstoakes@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Shuah Khan <shuah@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        Peter Xu <peterx@...hat.com>, Jason Gunthorpe <jgg@...dia.com>,
        John Hubbard <jhubbard@...dia.com>, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH v1 1/3] selftests/mm: factor out detection of hugetlb page
 sizes into vm_util

On 28.05.23 16:49, Lorenzo Stoakes wrote:
> On Fri, May 19, 2023 at 12:27:21PM +0200, David Hildenbrand wrote:
>> Let's factor detection out into vm_util, to be reused by a new test.
>>
> 
> Bit of a nit as it's hardly vitally important, but perhaps worth mentioning
> that you also refactor the function to accept any array (this is a
> requirement rather than simply refactoring a thing but still :)

Well, the function used to, and still does accept an array. It's just a 
more human-friendly way of expressing that.

If I have to resend the whole patchset, I can add a note "While at it, 
make the function accept an array instead of a raw pointer.".

[...]

> 
> Looks good to me,
> 
> Reviewed-by: Lorenzo Stoakes <lstoakes@...il.com>
> 

Thanks!

-- 
Thanks,

David / dhildenb