linux-kernel - Re: [PATCH] ARM: Replace all non-returning strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXGETX_zD=Us+E3+c0f1Cs3OA3gmZrR3Q-xhdh047V3-TQ@mail.gmail.com>
Date:   Thu, 1 Jun 2023 10:35:01 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Azeem Shaikh <azeemshaikh38@...il.com>,
        Russell King <linux@...linux.org.uk>,
        linux-hardening@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
        Amit Daniel Kachhap <amit.kachhap@....com>
Subject: Re: [PATCH] ARM: Replace all non-returning strlcpy with strscpy

On Wed, 31 May 2023 at 15:30, Linus Walleij <linus.walleij@...aro.org> wrote:
>
> On Tue, May 30, 2023 at 5:55 PM Azeem Shaikh <azeemshaikh38@...il.com> wrote:
>
> > strlcpy() reads the entire source buffer first.
> > This read may exceed the destination size limit.
> > This is both inefficient and can lead to linear read
> > overflows if a source string is not NUL-terminated [1].
> > In an effort to remove strlcpy() completely [2], replace
> > strlcpy() here with strscpy().
> > No return values were used, so direct replacement is safe.
> >
> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> > [2] https://github.com/KSPP/linux/issues/89
> >
> > Signed-off-by: Azeem Shaikh <azeemshaikh38@...il.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>
> Please put this into Russell's patch tracker:
> https://www.arm.linux.org.uk/developer/patches/
>

https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9300/1