[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2023060142-thyself-flatware-26f7@gregkh>
Date: Thu, 1 Jun 2023 10:03:01 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Luka Perkov <luka.perkov@...tura.hr>,
Robert Marko <robert.marko@...tura.hr>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] nvmem: core: Expose cells through sysfs
On Thu, Jun 01, 2023 at 10:51:14AM +0200, Miquel Raynal wrote:
> > > + /* Without exposed cells, successfully exit after
> > > assigning an empty attributes array */
> > > + if (!ncells)
> > > + goto unlock_mutex;
> >
> > Shouldn't this check be higher up _before_ you allocate any memory?
> > If the attribute group list is empty, nothing should be created,
> > right? Or will the driver core crash?
>
> As you rightfully guessed it, the core will crash if no list is
> provided at all. I need to provide an empty list with just an empty
> member and everything goes smoothly.
Let's fix the core, it shouldn't crash like that :)
thanks,
greg k-h
Powered by blists - more mailing lists