linux-kernel - Re: [PATCH v1 1/1] scsi: ufs: core: Fix ufshcd_inc_sq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <962ae163-ffc1-6e4b-35b9-dd893a49d038@quicinc.com>
Date:   Thu, 1 Jun 2023 03:27:19 -0700
From:   "Bao D. Nguyen" <quic_nguyenb@...cinc.com>
To:     Zhang Hui <masonzhang.xiaomi@...il.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        Bart Van Assche <bvanassche@....org>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>
CC:     Can Guo <quic_cang@...cinc.com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Asutosh Das <quic_asutoshd@...cinc.com>,
        Arthur Simchaev <Arthur.Simchaev@....com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        zhanghui <zhanghui31@...omi.com>, Bean Huo <beanhuo@...ron.com>,
        <peng.zhou@...iatek.com>, <yudongbin@...omi.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/1] scsi: ufs: core: Fix ufshcd_inc_sq_tail function
 bug

On 6/1/2023 2:13 AM, Zhang Hui wrote:
> From: zhanghui <zhanghui31@...omi.com>
> 
> If q->max_entries is not multiple of 32, mask not every bit is 1.
> So q->sq_tail_slot some bit will be cleared by use this way.
Hi Zhang,
Maybe reword the commit message a little bit? Otherwise, it is a good patch.

Reviewed-by: Bao D. Nguyen <quic_nguyenb@...cinc.com>