linux-kernel - Re: [PATCH] serial: core: Don't drop port_mutex in serial_core_remove_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230601105825.GZ14287@atomide.com>
Date:   Thu, 1 Jun 2023 13:58:25 +0300
From:   Tony Lindgren <tony@...mide.com>
To:     Steven Price <steven.price@....com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-omap@...r.kernel.org, Vignesh Raghavendra <vigneshr@...com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Johan Hovold <johan@...nel.org>,
        John Ogness <john.ogness@...utronix.de>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Dhruva Gole <d-gole@...com>
Subject: Re: [PATCH] serial: core: Don't drop port_mutex in
 serial_core_remove_one_port

* Steven Price <steven.price@....com> [230601 10:56]:
> Commit 84a9582fd203 ("serial: core: Start managing serial controllers to
> enable runtime PM") required the caller to hold port_mutex rather than
> taking it locally. However the mutex_unlock() call wasn't removed
> causing the mutex to be dropped unexpectly. Remove the call to
> mutex_unlock() (and fix up the early return) to restore correct
> behaviour.
> 
> Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM")

Reviewed-by: Tony Lindgren <tony@...mide.com>