linux-kernel - Re: [PATCH] arm64: dts: ti: k3-j784s4: Fix wakeup pinmux range and pinctrl node offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4aee3a8f-66ff-387b-73a1-31fc16eb7ffc@ti.com>
Date:   Thu, 1 Jun 2023 17:18:56 +0530
From:   Thejasvi Konduru <t-konduru@...com>
To:     Nishanth Menon <nm@...com>
CC:     Tero Kristo <kristo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Andrew Davis <afd@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Apurva Nandan <a-nandan@...com>, Udit Kumar <u-kumar1@...com>
Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4: Fix wakeup pinmux range and
 pinctrl node offsets

On 09/05/23 15:19, Thejasvi Konduru wrote:
>
> On 04/05/23 19:52, Nishanth Menon wrote:
>> On 17:40-20230504, Thejasvi Konduru wrote:
>>> On 04/05/23 17:22, Nishanth Menon wrote:
>>>> On 14:36-20230504, Thejasvi Konduru wrote:
>>>>> On 03/05/23 17:16, Nishanth Menon wrote:
>>>>>> On 14:01-20230503, Thejasvi Konduru wrote:
>>>>>>> The wkup_pmx register region in j784s4 has multiple non-addressable
>>>>>>> regions, hence the existing wkup_pmx region is split as follows to
>>>>>>> avoid the non-addressable regions. The pinctrl node offsets are
>>>>>>> also corrected as per the newly split wkup_pmx* nodes.
>>>>>>>
>>>>>>> wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12)
>>>>>>> wkup_pmx1 -> 11 pins (WKUP_PADCONFIG 14 - 24)
>>>>>>> wkup_pmx2 -> 72 pins (WKUP_PADCONFIG 26 - 97)
>>>>>>> wkup_pmx3 -> 1 pin (WKUP_PADCONFIG 100)
>>>>>>>
>>>>>>> Fixes: 4664ebd8346a ("arm64: dts: ti: Add initial support for 
>>>>>>> J784S4 SoC")
>>>>>>> Signed-off-by: Thejasvi Konduru <t-konduru@...com>
>>>>>>> ---
>>>>>> Could you provide a link to the output of:
>>>>>> $ cat /sys/kernel/debug/pinctrl/*/pins
>>>>> https://gist.github.com/thejasvikonduru/05b1a8e0fd8176116b7a3cc4e43b244a 
>>>>>
>>>> Was this failing prior to this patch? Trying to understand the "Fix"
>>>> aspect of this patch.
>>>>
>>> Yes,it was failing prior to this patch.
>>>
>> next time some asks this question - give summary AND give a log. Even
>> better, please don't make folks even ask the question in the first
>> place by including the logs in the diffstat of the patch.
>>
>> Please share the log to understand what kind of "failure" was occurring.
>
> Link to logs:
> Before Fix: 
> https://gist.github.com/thejasvikonduru/e217edf4839c348793a5671aa9331595
> After Fix : 
> https://gist.github.com/thejasvikonduru/05b1a8e0fd8176116b7a3cc4e43b244a
>
Are these logs fine and can we go forward with this patch?