linux-kernel - Re: [PATCH] memblock: Update nid info in memblock debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALJQGLn7b9n8BMn6fQuUgz08oHiMPeguWr5EAPSubQkQe4V0dw@mail.gmail.com>
Date:   Thu, 1 Jun 2023 20:33:06 +0800
From:   Yuwei Guan <ssawgyw@...il.com>
To:     Mike Rapoport <rppt@...nel.org>
Cc:     akpm@...ux-foundation.org, wangkefeng.wang@...wei.com,
        anshuman.khandual@....com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memblock: Update nid info in memblock debugfs

Mike Rapoport <rppt@...nel.org> 于2023年6月1日周四 13:21写道：
>
> On Mon, May 29, 2023 at 02:20:02PM +0800, Yuwei Guan wrote:
> > The node id for memblock reserved regions will be wrong,
> > so let's show 'x' for reg->nid == MAX_NUMNODES in debugfs to keep it align.
> >
> > Suggested-by: Mike Rapoport (IBM) <rppt@...nel.org>
> > Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> > Signed-off-by: Yuwei Guan <ssawgyw@...il.com>
>
> I believe this could use Co-developed-by tags.
> Please take a look at Documentation/process/submitting-patches.rst
>
Hi Mike,

Thanks, I will look into it, and resend this patch soon.
> > ---
> >  mm/memblock.c | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/mm/memblock.c b/mm/memblock.c
> > index c5c80d9bcea3..3d449aaba052 100644
> > --- a/mm/memblock.c
> > +++ b/mm/memblock.c
> > @@ -2169,17 +2169,21 @@ static int memblock_debug_show(struct seq_file *m, void *private)
> >  {
> >       struct memblock_type *type = m->private;
> >       struct memblock_region *reg;
> > -     int i, j;
> > +     int i, j, nid;
> >       unsigned int count = ARRAY_SIZE(flagname);
> >       phys_addr_t end;
> >
> >       for (i = 0; i < type->cnt; i++) {
> >               reg = &type->regions[i];
> >               end = reg->base + reg->size - 1;
> > +             nid = memblock_get_region_node(reg);
> >
> >               seq_printf(m, "%4d: ", i);
> >               seq_printf(m, "%pa..%pa ", &reg->base, &end);
> > -             seq_printf(m, "%4d ", memblock_get_region_node(reg));
> > +             if (nid != MAX_NUMNODES)
> > +                     seq_printf(m, "%4d ", nid);
> > +             else
> > +                     seq_printf(m, "%4c ", 'x');
> >               if (reg->flags) {
> >                       for (j = 0; j < count; j++) {
> >                               if (reg->flags & (1U << j)) {
> > --
> > 2.34.1
> >
>
> --
> Sincerely yours,
> Mike.