[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230601154154.57ae1b93@redslave.neermore.group>
Date: Thu, 1 Jun 2023 15:41:54 +0300
From: Nikita Shubin <nikita.shubin@...uefel.me>
To: Mark Brown <broonie@...nel.org>
Cc: Alexander Sverdlin <alexander.sverdlin@...il.com>,
Arnd Bergmann <arnd@...db.de>,
Linus Walleij <linus.walleij@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Michael Peters <mpeters@...eddedts.com>,
Kris Bahnsen <kris@...eddedts.com>, linux-spi@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 17/43] dt-bindings: spi: Add Cirrus EP93xx
Hello Mark!
On Thu, 1 Jun 2023 12:17:27 +0100
Mark Brown <broonie@...nel.org> wrote:
> On Thu, Jun 01, 2023 at 08:34:08AM +0300, Nikita Shubin wrote:
>
> > + cirrus,ep9301-use-dma:
> > + description: Flag indicating that the SPI should use dma
> > + type: boolean
>
> My previous feedback on this property still applies.
>
> Please don't ignore review comments, people are generally making them
> for a reason and are likely to have the same concerns if issues remain
> unaddressed. Having to repeat the same comments can get repetitive
> and make people question the value of time spent reviewing. If you
> disagree with the review comments that's fine but you need to reply
> and discuss your concerns so that the reviewer can understand your
> decisions.
Sorry - that was totally unintentional, i was tinkering with spi and
got distracted on other part of this series (it's quite big for me,
first time tinkering with a series more than 5-6 patches).
> > + cirrus,ep9301-use-dma:
The reason is that ep93xx DMA state is not quite device-tree ready at
this moment, and clients use it with the help of:
https://elixir.bootlin.com/linux/v6.4-rc4/source/include/linux/platform_data/dma-ep93xx.h
I was hoping to slip by without changing much in ep93xx DMA driver, so
i can deal with it later, especially seeing it's having some quirks
like:
https://elixir.bootlin.com/linux/v6.4-rc4/source/drivers/dma/ep93xx_dma.c#L471
And edb93xx and bk3 don't set use_dma with SPI for some reason.
I can move "use-dma" to module parameters, if this is acceptable.
Powered by blists - more mailing lists