| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230601132759.li7t35pw35gfg6i7@demise>
Date: Thu, 1 Jun 2023 08:27:59 -0500
From: Nishanth Menon <nm@...com>
To: Hari Nagalla <hnagalla@...com>
CC: <vigneshr@...com>, <kristo@...nel.org>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-j721s2-main: Add R5F and C7x
remote processsor nodes
On 17:09-20230529, Hari Nagalla wrote:
> The J721S2 SoCs have 2 dual-core Arm Cortex-R5F processor (R5FSS)
> subsystems/clusters in MAIN voltage domain. Each of these can be
> configured at boot time to be either run in a LockStep mode or in an
> Asymmetric Multi Processing (AMP) fashion in Split-mode. These
> subsystems have 64 KB each Tightly-Coupled Memory (TCM) internal
> memories for each core split between two banks - ATCM and BTCM
> (further interleaved into two banks). The TCMs of both Cores are
> combined in LockStep-mode to provide a larger 128 KB of memory, but
> otherwise are functionally similar to those on J721E SoCs.
>
> Add the DT nodes for the MAIN domain R5F cluster/subsystems, the two
> R5F cores are added as child nodes to each of the R5F cluster nodes.
> The clusters are configured to run in LockStep mode by default, with
> the ATCMs enabled to allow the R5 cores to execute code from DDR
> with boot-strapping code from ATCM. The inter-processor communication
> between the main A72 cores and these processors is achieved through
> shared memory and Mailboxes.
>
> The following firmware names are used by default for these cores, and
> can be overridden in a board dts file if desired:
> MAIN R5FSS0 Core0: j721s2-main-r5f0_0-fw (both in LockStep & Split modes)
> MAIN R5FSS0 Core1: j721s2-main-r5f0_1-fw (needed only in Split mode)
> MAIN R5FSS1 Core0: j721s2-main-r5f1_0-fw (both in LockStep & Split modes)
> MAIN R5FSS1 Core1: j721s2-main-r5f1_1-fw (needed only in Split mode)
>
> The K3 J721S2 SoCs have two C71x DSP subsystems in MAIN voltage domain. The
> C71x DSPs are 64 bit machine with fixed and floating point DSP operations.
> Similar to the R5F remote cores, the inter-processor communication
> between the main A72 cores and these DSP cores is achieved through
> shared memory and Mailboxes.
>
> The following firmware names are used by default for these DSP cores,
> and can be overridden in a board dts file if desired:
> MAIN C71_0 : j721s2-c71_0-fw
> MAIN C71_1 : j721s2-c71_1-fw
>
> Signed-off-by: Hari Nagalla <hnagalla@...com>
> ---
> arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 128 +++++++++++++++++----
> 1 file changed, 104 insertions(+), 24 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> index 2dd7865f7654..361aa6b24b22 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> @@ -463,7 +463,6 @@ mailbox0_cluster0: mailbox@...80000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
See https://lore.kernel.org/all/20221020160305.18711-9-afd@ti.com/
NAK.
> };
>
> mailbox0_cluster1: mailbox@...81000 {
> @@ -473,7 +472,6 @@ mailbox0_cluster1: mailbox@...81000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox0_cluster2: mailbox@...82000 {
> @@ -483,7 +481,6 @@ mailbox0_cluster2: mailbox@...82000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox0_cluster3: mailbox@...83000 {
> @@ -493,7 +490,6 @@ mailbox0_cluster3: mailbox@...83000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox0_cluster4: mailbox@...84000 {
> @@ -503,7 +499,6 @@ mailbox0_cluster4: mailbox@...84000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox0_cluster5: mailbox@...85000 {
> @@ -513,7 +508,6 @@ mailbox0_cluster5: mailbox@...85000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox0_cluster6: mailbox@...86000 {
> @@ -523,7 +517,6 @@ mailbox0_cluster6: mailbox@...86000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox0_cluster7: mailbox@...87000 {
> @@ -533,7 +526,6 @@ mailbox0_cluster7: mailbox@...87000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox0_cluster8: mailbox@...88000 {
> @@ -543,7 +535,6 @@ mailbox0_cluster8: mailbox@...88000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox0_cluster9: mailbox@...89000 {
> @@ -553,7 +544,6 @@ mailbox0_cluster9: mailbox@...89000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox0_cluster10: mailbox@...8a000 {
> @@ -563,7 +553,6 @@ mailbox0_cluster10: mailbox@...8a000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox0_cluster11: mailbox@...8b000 {
> @@ -573,7 +562,6 @@ mailbox0_cluster11: mailbox@...8b000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox1_cluster0: mailbox@...90000 {
> @@ -583,7 +571,6 @@ mailbox1_cluster0: mailbox@...90000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox1_cluster1: mailbox@...91000 {
> @@ -593,7 +580,6 @@ mailbox1_cluster1: mailbox@...91000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox1_cluster2: mailbox@...92000 {
> @@ -603,7 +589,6 @@ mailbox1_cluster2: mailbox@...92000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox1_cluster3: mailbox@...93000 {
> @@ -613,7 +598,6 @@ mailbox1_cluster3: mailbox@...93000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox1_cluster4: mailbox@...94000 {
> @@ -623,7 +607,6 @@ mailbox1_cluster4: mailbox@...94000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox1_cluster5: mailbox@...95000 {
> @@ -633,7 +616,6 @@ mailbox1_cluster5: mailbox@...95000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox1_cluster6: mailbox@...96000 {
> @@ -643,7 +625,6 @@ mailbox1_cluster6: mailbox@...96000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox1_cluster7: mailbox@...97000 {
> @@ -653,7 +634,6 @@ mailbox1_cluster7: mailbox@...97000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox1_cluster8: mailbox@...98000 {
> @@ -663,7 +643,6 @@ mailbox1_cluster8: mailbox@...98000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox1_cluster9: mailbox@...99000 {
> @@ -673,7 +652,6 @@ mailbox1_cluster9: mailbox@...99000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox1_cluster10: mailbox@...9a000 {
> @@ -683,7 +661,6 @@ mailbox1_cluster10: mailbox@...9a000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> mailbox1_cluster11: mailbox@...9b000 {
> @@ -693,7 +670,6 @@ mailbox1_cluster11: mailbox@...9b000 {
> ti,mbox-num-users = <4>;
> ti,mbox-num-fifos = <16>;
> interrupt-parent = <&main_navss_intr>;
> - status = "disabled";
> };
>
> main_ringacc: ringacc@...00000 {
> @@ -1102,4 +1078,108 @@ main_spi7: spi@...0000 {
> clocks = <&k3_clks 346 1>;
> status = "disabled";
> };
> +
> + main_r5fss0: r5fss@...0000 {
> + compatible = "ti,j721s2-r5fss";
> + ti,cluster-mode = <1>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x5c00000 0x00 0x5c00000 0x20000>,
> + <0x5d00000 0x00 0x5d00000 0x20000>;
> + power-domains = <&k3_pds 277 TI_SCI_PD_EXCLUSIVE>;
> +
> + main_r5fss0_core0: r5f@...0000 {
> + compatible = "ti,j721s2-r5f";
> + reg = <0x5c00000 0x00010000>,
> + <0x5c10000 0x00010000>;
> + reg-names = "atcm", "btcm";
> + ti,sci = <&sms>;
> + ti,sci-dev-id = <279>;
> + ti,sci-proc-ids = <0x06 0xff>;
> + resets = <&k3_reset 279 1>;
> + firmware-name = "j721s2-main-r5f0_0-fw";
> + ti,atcm-enable = <1>;
> + ti,btcm-enable = <1>;
> + ti,loczrama = <1>;
> + };
> +
> + main_r5fss0_core1: r5f@...0000 {
> + compatible = "ti,j721s2-r5f";
> + reg = <0x5d00000 0x00010000>,
> + <0x5d10000 0x00010000>;
> + reg-names = "atcm", "btcm";
> + ti,sci = <&sms>;
> + ti,sci-dev-id = <280>;
> + ti,sci-proc-ids = <0x07 0xff>;
> + resets = <&k3_reset 280 1>;
> + firmware-name = "j721s2-main-r5f0_1-fw";
> + ti,atcm-enable = <1>;
> + ti,btcm-enable = <1>;
> + ti,loczrama = <1>;
> + };
> + };
> +
> + main_r5fss1: r5fss@...0000 {
> + compatible = "ti,j721s2-r5fss";
> + ti,cluster-mode = <1>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x5e00000 0x00 0x5e00000 0x20000>,
> + <0x5f00000 0x00 0x5f00000 0x20000>;
> + power-domains = <&k3_pds 278 TI_SCI_PD_EXCLUSIVE>;
> +
> + main_r5fss1_core0: r5f@...0000 {
> + compatible = "ti,j721s2-r5f";
> + reg = <0x5e00000 0x00010000>,
> + <0x5e10000 0x00010000>;
> + reg-names = "atcm", "btcm";
> + ti,sci = <&sms>;
> + ti,sci-dev-id = <281>;
> + ti,sci-proc-ids = <0x08 0xff>;
> + resets = <&k3_reset 281 1>;
> + firmware-name = "j721s2-main-r5f1_0-fw";
> + ti,atcm-enable = <1>;
> + ti,btcm-enable = <1>;
> + ti,loczrama = <1>;
> + };
> +
> + main_r5fss1_core1: r5f@...0000 {
> + compatible = "ti,j721s2-r5f";
> + reg = <0x5f00000 0x00010000>,
> + <0x5f10000 0x00010000>;
> + reg-names = "atcm", "btcm";
> + ti,sci = <&sms>;
> + ti,sci-dev-id = <282>;
> + ti,sci-proc-ids = <0x09 0xff>;
> + resets = <&k3_reset 282 1>;
> + firmware-name = "j721s2-main-r5f1_1-fw";
> + ti,atcm-enable = <1>;
> + ti,btcm-enable = <1>;
> + ti,loczrama = <1>;
> + };
> + };
> +
> + c71_0: dsp@...00000 {
> + compatible = "ti,j721s2-c71-dsp";
> + reg = <0x00 0x64800000 0x00 0x00080000>,
> + <0x00 0x64e00000 0x00 0x0000c000>;
> + reg-names = "l2sram", "l1dram";
> + ti,sci = <&sms>;
> + ti,sci-dev-id = <8>;
> + ti,sci-proc-ids = <0x30 0xff>;
> + resets = <&k3_reset 8 1>;
> + firmware-name = "j721s2-c71_0-fw";
> + };
> +
> + c71_1: dsp@...00000 {
> + compatible = "ti,j721s2-c71-dsp";
> + reg = <0x00 0x65800000 0x00 0x00080000>,
> + <0x00 0x65e00000 0x00 0x0000c000>;
> + reg-names = "l2sram", "l1dram";
> + ti,sci = <&sms>;
> + ti,sci-dev-id = <11>;
> + ti,sci-proc-ids = <0x31 0xff>;
> + resets = <&k3_reset 11 1>;
> + firmware-name = "j721s2-c71_1-fw";
> + };
> };
> --
> 2.34.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Powered by blists - more mailing lists