linux-kernel - Re: [PATCH V2 2/6] clk: qcom: Update l value configuration for lucid ole and evo plls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42f94fbc-ca0a-7441-2e4f-9dbc276da04f@quicinc.com>
Date:   Thu, 1 Jun 2023 19:50:47 +0530
From:   Jagadeesh Kona <quic_jkona@...cinc.com>
To:     Bryan O'Donoghue <pure.logic@...us-software.ie>,
        Andy Gross <agross@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        "Stephen Boyd" <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
CC:     Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
        Vinod Koul <vkoul@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-clk@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Taniya Das <quic_tdas@...cinc.com>,
        Satya Priya Kakitapalli <quic_skakitap@...cinc.com>,
        Imran Shaik <quic_imrashai@...cinc.com>,
        Ajit Pandey <quic_ajipan@...cinc.com>
Subject: Re: [PATCH V2 2/6] clk: qcom: Update l value configuration for lucid
 ole and evo plls

Hi Bryan,

Thanks for your review!

On 5/26/2023 6:52 PM, Bryan O'Donoghue wrote:
> On 25/05/2023 18:21, Jagadeesh Kona wrote:
>> -    .config_ctl_hi1_val = 0x32AA299C,
>> +    .config_ctl_hi1_val = 0x32aa299c,
> 
> You should separate out this change from this patch.
> 
> There's nothing wrong with having a preliminary patch to change all 
> upper-case HEX to lowercase hex.
> 
> You should do that since the log here "update l value" != change UCASE 
> to lcase hex.
> 
Sure, will remove this in the next series.
> ---
> 0xb0d

Thanks & Regards,
Jagadeesh