linux-kernel - Re: [PATCH v3] net/sctp: Make sha1 as default algorithm if fips is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHoHfcMgYqO3l7Np@corigine.com>
Date:   Fri, 2 Jun 2023 17:15:09 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Ashwin Dayanand Kamat <kashwindayan@...are.com>
Cc:     Vlad Yasevich <vyasevich@...il.com>,
        Neil Horman <nhorman@...driver.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-sctp@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        amakhalov@...are.com, vsirnapalli@...are.com, akaher@...are.com,
        tkundu@...are.com, keerthanak@...are.com,
        Xin Long <lucien.xin@...il.com>
Subject: Re: [PATCH v3] net/sctp: Make sha1 as default algorithm if fips is
 enabled

+ Xin Long

On Thu, Jun 01, 2023 at 11:47:54PM +0530, Ashwin Dayanand Kamat wrote:
> MD5 is not FIPS compliant. But still md5 was used as the
> default algorithm for sctp if fips was enabled.
> Due to this, listen() system call in ltp tests was
> failing for sctp in fips environment, with below error message.
> 
> [ 6397.892677] sctp: failed to load transform for md5: -2
> 
> Fix is to not assign md5 as default algorithm for sctp
> if fips_enabled is true. Instead make sha1 as default algorithm.
> The issue fixes ltp testcase failure "cve-2018-5803 sctp_big_chunk"
> 
> Signed-off-by: Ashwin Dayanand Kamat <kashwindayan@...are.com>
> ---
> v3:
> * Resolved hunk failures.
> * Changed the ratelimited notice to be more meaningful.
> * Used ternary condition for if/else condtion.
> v2:
> * The listener can still fail if fips mode is enabled after
>   that the netns is initialized.
> * Fixed this in sctp_listen_start() as suggested by
>   Paolo Abeni <pabeni@...hat.com>

FWIIW, this seems reasonable to me.

Reviewed-by: Simon Horman <simon.horman@...igine.com>