linux-kernel - Re: [PATCH v3 1/4] include/linux/suspend.h: Only show pm_pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHlNGF79cwicmWde@surfacebook>
Date:   Fri, 2 Jun 2023 04:59:52 +0300
From:   andy.shevchenko@...il.com
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     Rafael Wysocki <rafael@...nel.org>, hdegoede@...hat.com,
        linus.walleij@...aro.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        platform-driver-x86@...r.kernel.org, linux-pm@...r.kernel.org,
        S-k Shyam-sundar <Shyam-sundar.S-k@....com>,
        Natikar Basavaraj <Basavaraj.Natikar@....com>
Subject: Re: [PATCH v3 1/4] include/linux/suspend.h: Only show pm_pr_dbg
 messages at suspend/resume

Thu, Jun 01, 2023 at 06:29:20PM -0500, Mario Limonciello kirjoitti:
> All uses in the kernel are currently already oriented around
> suspend/resume. As some other parts of the kernel may also use these
> messages in functions that could also be used outside of
> suspend/resume, only enable in suspend/resume path.

...

>  * Remove pointless do/while

I believe this is a joke.

This guards against weirdness, like

	__pm_pr_dbg(foo)
	else
		bar;

NAK for this particular change.

-- 
With Best Regards,
Andy Shevchenko