linux-kernel - Re: [PATCH 03/12] selftests/mm: fix unused variable warning in migration.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6c8a92f-dd4b-436f-9eea-8d24ba491e6c@nvidia.com>
Date:   Fri, 2 Jun 2023 11:39:50 -0700
From:   John Hubbard <jhubbard@...dia.com>
To:     David Hildenbrand <david@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>
CC:     Peter Xu <peterx@...hat.com>, Shuah Khan <shuah@...nel.org>,
        "Nathan Chancellor" <nathan@...nel.org>, <linux-mm@...ck.org>,
        <linux-kselftest@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 03/12] selftests/mm: fix unused variable warning in
 migration.c

On 6/2/23 03:02, David Hildenbrand wrote:
> On 02.06.23 03:33, John Hubbard wrote:
>> Declare the variable as volatile, in order to avoid the clang compiler
>> warning.
>>
>> Signed-off-by: John Hubbard <jhubbard@...dia.com>
>> ---
>>   tools/testing/selftests/mm/migration.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/mm/migration.c b/tools/testing/selftests/mm/migration.c
>> index 1cec8425e3ca..2dede662ff43 100644
>> --- a/tools/testing/selftests/mm/migration.c
>> +++ b/tools/testing/selftests/mm/migration.c
>> @@ -95,7 +95,7 @@ int migrate(uint64_t *ptr, int n1, int n2)
>>   void *access_mem(void *ptr)
>>   {
>> -    uint64_t y = 0;
>> +    volatile uint64_t y = 0;
>>       volatile uint64_t *x = ptr;
>>       while (1) {
> 
> Same comment as for previous patch.
> 

Yes. In fact I'll merge this one into the previous patch, since
they are so similar and small, and have the same fix approach.

thanks,
-- 
John Hubbard
NVIDIA