linux-kernel - Re: [PATCH] tpm, tpm_tis: correct tpm_tis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Jun 2023 21:21:14 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Lino Sanfilippo <LinoSanfilippo@....de>
Cc:     jarkko@...nel.org, gregkh@...uxfoundation.org, pavel@...x.de,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
        patches@...nelci.org, lkft-triage@...ts.linaro.org,
        jonathanh@...dia.com, f.fainelli@...il.com,
        sudipm.mukherjee@...il.com, srw@...dewatkins.net, rwarsow@....de,
        linux-integrity@...r.kernel.org, l.sanfilippo@...bus.com,
        lukas@...ner.de, p.rosenberger@...bus.com, stable@...r.kernel.org
Subject: Re: [PATCH] tpm, tpm_tis: correct tpm_tis_flags enumeration values

Hi!

> From: Lino Sanfilippo <l.sanfilippo@...bus.com>
> 
> With commit 858e8b792d06 ("tpm, tpm_tis: Avoid cache incoherency in test
> for interrupts") bit accessor functions are used to access flags in
> tpm_tis_data->flags.
> 
> However these functions expect bit numbers, while the flags are defined as
> bit masks in enum tpm_tis_flag.
> 
> Fix this inconsistency by using numbers instead of masks also for the flags
> in the enum.
> 

Reviewed-by: Pavel Machek <pavel@...x.de>

Thank you!

Best regards,
									Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)