linux-kernel - [PATCH 1/2] accel/qaic: Free user handle on interrupted mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230602210440.8411-2-quic_jhugo@quicinc.com>
Date:   Fri, 2 Jun 2023 15:04:39 -0600
From:   Jeffrey Hugo <quic_jhugo@...cinc.com>
To:     <dri-devel@...ts.freedesktop.org>
CC:     <ogabbay@...nel.org>, <jacek.lawrynowicz@...ux.intel.com>,
        <stanislaw.gruszka@...ux.intel.com>, <quic_carlv@...cinc.com>,
        <quic_ajitpals@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@...cinc.com>,
        Jeffrey Hugo <quic_jhugo@...cinc.com>
Subject: [PATCH 1/2] accel/qaic: Free user handle on interrupted mutex

From: Carl Vanderlip <quic_carlv@...cinc.com>

After user handle is allocated, if mutex is interrupted, we do not free
the user handle and return an error. Kref had been initialized, but not
added to users list, so device teardown would also not call free_usr.

Fixes: c501ca23a6a3 ("accel/qaic: Add uapi and core driver file")
Signed-off-by: Carl Vanderlip <quic_carlv@...cinc.com>
Reviewed-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@...cinc.com>
Reviewed-by: Jeffrey Hugo <quic_jhugo@...cinc.com>
Signed-off-by: Jeffrey Hugo <quic_jhugo@...cinc.com>
---
 drivers/accel/qaic/qaic_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/accel/qaic/qaic_drv.c b/drivers/accel/qaic/qaic_drv.c
index 2d0828db28d8..961cd341b414 100644
--- a/drivers/accel/qaic/qaic_drv.c
+++ b/drivers/accel/qaic/qaic_drv.c
@@ -97,6 +97,7 @@ static int qaic_open(struct drm_device *dev, struct drm_file *file)
 
 cleanup_usr:
 	cleanup_srcu_struct(&usr->qddev_lock);
+	ida_free(&qaic_usrs, usr->handle);
 free_usr:
 	kfree(usr);
 dev_unlock:
-- 
2.40.1