linux-kernel - Re: [PATCH] gpio: ath79: Add missing check for platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230602031526.45447-1-jiasheng@iscas.ac.cn>
Date:   Fri,  2 Jun 2023 11:15:26 +0800
From:   Jiasheng Jiang <jiasheng@...as.ac.cn>
To:     andy.shevchenko@...il.com
Cc:     albeu@...e.fr, linus.walleij@...aro.org, brgl@...ev.pl,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jiasheng Jiang <jiasheng@...as.ac.cn>
Subject: Re: [PATCH] gpio: ath79: Add missing check for platform_get_irq

Thu, Jun 02, 2023 at 09:32:00 +0800, Andy Shevchenko wrote:
> Thu, Jun 01, 2023 at 04:51:32PM +0800, Jiasheng Jiang kirjoitti:
>> Add the missing check for platform_get_irq and return error
>> if it fails.
> 
>>  		girq->parents[0] = platform_get_irq(pdev, 0);
>> +		if (girq->parents[0] < 0)
>> +			return -ENODEV;
> 
> Can you elaborate why error code has to be shadowed (overriden)?

You are right.
Returning the error code is better.
I will submit a v2.
The same goes for the other patch
"gpio: sifive: Add missing check for platform_get_irq".

Thanks,
Jiasheng