linux-kernel - Re: [PATCH] usb: typec: mux: Fix extraneous semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Jun 2023 08:45:26 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Prashant Malani <pmalani@...omium.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Arnd Bergmann <arnd@...db.de>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: mux: Fix extraneous semicolon

On Thu, Jun 01, 2023 at 11:33:37PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> A recent patch introduced a typo in the fwnode_typec_mux_get()
> stub function that causes a build failure in some configurations:
> 
> In file included from drivers/phy/qualcomm/phy-qcom-qmp-combo.c:23:
> include/linux/usb/typec_mux.h:77:1: error: expected identifier or '(' before '{' token
> include/linux/usb/typec_mux.h:76:33: error: 'fwnode_typec_mux_get' used but never defined [-Werror]
> 
> Fixes: 3524fe31538c1 ("usb: typec: mux: Remove alt mode parameters from the API")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  include/linux/usb/typec_mux.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/usb/typec_mux.h b/include/linux/usb/typec_mux.h
> index 11bfa314529fd..2489a7857d8e1 100644
> --- a/include/linux/usb/typec_mux.h
> +++ b/include/linux/usb/typec_mux.h
> @@ -73,7 +73,7 @@ void *typec_mux_get_drvdata(struct typec_mux_dev *mux);
>  
>  #else
>  
> -static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode);
> +static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode)
>  {
>  	return NULL;
>  }
> -- 
> 2.39.2
> 

Should already be fixed in my tree, and in the next linux-next, sorry.

greg k-h