linux-kernel - Re: [PATCH RESEND 4/4] arm64: dts: qcom: ipq5332: add support for the RDP474 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <196c085f-8772-0259-4a26-511f4ab05bcb@quicinc.com>
Date:   Fri, 2 Jun 2023 13:52:11 +0530
From:   Kathiravan T <quic_kathirav@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND 4/4] arm64: dts: qcom: ipq5332: add support for the
 RDP474 variant


On 6/2/2023 12:34 PM, Krzysztof Kozlowski wrote:
> On 02/06/2023 06:05, Kathiravan T wrote:
>> On 6/1/2023 10:59 PM, Krzysztof Kozlowski wrote:
>>> On 01/06/2023 06:20, Kathiravan T wrote:
>>>> Add the initial device tree support for the Reference Design
>>>> Platform(RDP) 474 based on IPQ5332 family of SoC. This patch carries
>>>> the support for Console UART, eMMC, I2C and GPIO based buttons.
>>>>
>>>> Signed-off-by: Kathiravan T <quic_kathirav@...cinc.com>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/Makefile           |   1 +
>>>>    arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts | 112 ++++++++++++++++++++
>>>>    2 files changed, 113 insertions(+)
>>>>    create mode 100644 arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>>>> index 4f9e81253e18..0f8c763a9bd9 100644
>>>> --- a/arch/arm64/boot/dts/qcom/Makefile
>>>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>>>> @@ -7,6 +7,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-ifc6640.dtb
>>>>    dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-mi01.2.dtb
>>>>    dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-rdp442.dtb
>>>>    dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-rdp468.dtb
>>>> +dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-rdp474.dtb
>>>>    dtb-$(CONFIG_ARCH_QCOM)	+= ipq6018-cp01-c1.dtb
>>>>    dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk01.dtb
>>>>    dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk10-c1.dtb
>>>> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts
>>>> new file mode 100644
>>>> index 000000000000..085729a0fdf1
>>>> --- /dev/null
>>>> +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts
>>>> @@ -0,0 +1,112 @@
>>>> +// SPDX-License-Identifier: BSD-3-Clause
>>>> +/*
>>>> + * IPQ5332 RDP474 board device tree source
>>>> + *
>>>> + * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
>>>> + */
>>>> +
>>>> +/dts-v1/;
>>>> +
>>>> +#include <dt-bindings/gpio/gpio.h>
>>>> +#include <dt-bindings/input/input.h>
>>>> +#include "ipq5332.dtsi"
>>>> +
>>>> +/ {
>>>> +	model = "Qualcomm Technologies, Inc. IPQ5332 MI01.9";
>>>> +	compatible = "qcom,ipq5332-ap-mi01.9", "qcom,ipq5332";
>>>> +
>>>> +	aliases {
>>>> +		serial0 = &blsp1_uart0;
>>>> +	};
>>>> +
>>>> +	chosen {
>>>> +		stdout-path = "serial0";
>>>> +	};
>>>> +
>>>> +	gpio_keys {
>>> No, srsly, so not only ignored the tags but also feedback?
>>
>> Please correct me if I am wrong here..
>>
>> This is RESEND of V1 patches (only minor correction in the subject line
> I sent you three emails and I assumed you got my feedback, thus it
> should not have been resend...
>
>
>> in cover letter). Also I don't see review comments as such in original
>> V1 as well
>> https://lore.kernel.org/linux-arm-msm/20230531135048.19164-1-quic_kathirav@quicinc.com/
>>
>> Can you help to point out your review comments, I couldn't able to find out.
> ... but I don't see them on lore. So apparently you also did not get them.
>
> I apologize in such case. Mails are nicely sent in my outbox but
> apparently went to /dev/null.
>
> Original feedback:
>
> Same problems as with most of recent patches. No underscores in node names.


Ack. Will fix it in next spin.


> Best regards,
> Krzysztof
>