linux-kernel - Re: [PATCH 6/8] pinctrl: qcom: allow true compile testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71b1f98c-ce20-e6e6-14c6-e5ab2d66dd96@linaro.org>
Date:   Fri, 2 Jun 2023 11:17:17 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 6/8] pinctrl: qcom: allow true compile testing

On 02/06/2023 11:08, Konrad Dybcio wrote:
> 
> 
> On 1.06.2023 17:20, Krzysztof Kozlowski wrote:
>> Makefile selected Qualcomm pinctrl drivers only for ARCH_QCOM, making
>> any COMPILE_TEST options inside Kconfig ((ARCH_QCOM || COMPILE_TEST) or
>> (OF || COMPILE_TEST)) not effective.  Always descent to the qcom
>> subdirectory to fix this.  All individual drivers are selected in
>> Makefile via dedicated CONFIG entries, thus this should not have
>> functional impact except when compile testing.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
> Should analogous changes be made for all remaining
> obj-$(CONFIG_PINCTRL_VENDOR) entries?

Only for ones depending on ARCH_XXX and that requires actual compile
testing which might point to missing dependencies etc.

Entries depending on selectable PINCTRL_VENDOR are already
compile-testable (see Samsung for example).

Best regards,
Krzysztof