linux-kernel - Re: [PATCH] KVM: x86/pmu: Remove redundant check for MSR_IA32_DS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <168565360839.667711.17229671566468688990.b4-ty@google.com>
Date:   Thu,  1 Jun 2023 18:25:47 -0700
From:   Sean Christopherson <seanjc@...gle.com>
To:     Sean Christopherson <seanjc@...gle.com>,
        Like Xu <like.xu.linux@...il.com>,
        Jinrong Liang <ljr.kernel@...il.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        Wanpeng Li <wanpengli@...cent.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86/pmu: Remove redundant check for MSR_IA32_DS_AREA
 set handler

On Tue, 11 Apr 2023 21:03:38 +0800, Jinrong Liang wrote:
> After commit 2de154f541fc ("KVM: x86/pmu: Provide "error" semantics
> for unsupported-but-known PMU MSRs"), the guest_cpuid_has(DS) check
> is not necessary any more since if the guest supports X86_FEATURE_DS,
> it never returns 1. And if the guest does not support this feature,
> the set_msr handler will get false from kvm_pmu_is_valid_msr() before
> reaching this point. Therefore, the check will not be true in all cases
> and can be safely removed, which also simplifies the code and improves
> its readability.
> 
> [...]

Applied to kvm-x86 vmx, thanks!

[1/1] KVM: x86/pmu: Remove redundant check for MSR_IA32_DS_AREA set handler
      https://github.com/kvm-x86/linux/commit/33ab767c2628

--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes