linux-kernel - Re: [PATCH 1/2] mm/memory_hotplug: remove reset_node_managed_pages() in hotadd_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f125f0db-30fe-5452-4669-3e48f7856569@redhat.com>
Date:   Fri, 2 Jun 2023 13:49:33 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Haifeng Xu <haifeng.xu@...pee.com>
Cc:     osalvador@...e.de, rppt@...nel.org, mhocko@...nel.org,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mm/memory_hotplug: remove reset_node_managed_pages()
 in hotadd_init_pgdat()

On 01.06.23 18:26, Haifeng Xu wrote:
> managed pages has already been set to 0 in free_area_init_core_hotplug(),

"via zone_init_internals() on each zone"

> so it's pointless to reset again.
> 
> Signed-off-by: Haifeng Xu <haifeng.xu@...pee.com>
> ---
>   mm/memory_hotplug.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 8e0fa209d533..65e385f34679 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1210,7 +1210,6 @@ static pg_data_t __ref *hotadd_init_pgdat(int nid)
>   	 * online_pages() and offline_pages().
>   	 * TODO: should be in free_area_init_core_hotplug?
>   	 */
> -	reset_node_managed_pages(pgdat);
>   	reset_node_present_pages(pgdat);
>   
>   	return pgdat;

With that, reset_node_managed_pages() no longer needs to be exposed 
outside of mm/memblock.c

Can you unexport that function as well?

-- 
Thanks,

David / dhildenb