linux-kernel - Re: [PATCH v2] gpio: ath79: Add missing check for platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vdfvt-jxesWOgki+wV0QdVLidSVc6J+Fcm6dU4pxZYfPg@mail.gmail.com>
Date:   Fri, 2 Jun 2023 16:02:47 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     albeu@...e.fr, linus.walleij@...aro.org, brgl@...ev.pl,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] gpio: ath79: Add missing check for platform_get_irq

On Fri, Jun 2, 2023 at 10:33 AM Jiasheng Jiang <jiasheng@...as.ac.cn> wrote:
>
> Add the missing check for platform_get_irq and return error code
> if it fails.

The template for function references is func().
Otherwise looks fine to me
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
> ---
> Changelog:
>
> v1 -> v2:
>
> 1. Return "girq->parents[0]" instead of "-ENODEV".
> ---
>  drivers/gpio/gpio-ath79.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
> index aa0a954b8392..31ce2d5c6ba0 100644
> --- a/drivers/gpio/gpio-ath79.c
> +++ b/drivers/gpio/gpio-ath79.c
> @@ -286,6 +286,8 @@ static int ath79_gpio_probe(struct platform_device *pdev)
>                 if (!girq->parents)
>                         return -ENOMEM;
>                 girq->parents[0] = platform_get_irq(pdev, 0);
> +               if (girq->parents[0] < 0)
> +                       return girq->parents[0];
>                 girq->default_type = IRQ_TYPE_NONE;
>                 girq->handler = handle_simple_irq;
>         }
> --
> 2.25.1
>


-- 
With Best Regards,
Andy Shevchenko