linux-kernel - Re: [PATCH v6 5/9] serial: sc16is7xx: fix regression with GPIO configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20230602090629.aa1bee802aafae76ce4e1e60@hugovil.com>
Date:   Fri, 2 Jun 2023 09:06:29 -0400
From:   Hugo Villeneuve <hugo@...ovil.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     gregkh@...uxfoundation.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        jirislaby@...nel.org, jringle@...dpoint.com,
        tomasz.mon@...lingroup.com, l.perczak@...lintechnologies.com,
        linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        Hugo Villeneuve <hvilleneuve@...onoff.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH v6 5/9] serial: sc16is7xx: fix regression with GPIO
 configuration

On Fri, 2 Jun 2023 15:58:43 +0300
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Fri, Jun 2, 2023 at 4:25 AM Hugo Villeneuve <hugo@...ovil.com> wrote:
> > On Thu, 1 Jun 2023 20:41:40 -0400
> > Hugo Villeneuve <hugo@...ovil.com> wrote:
> > > On Fri, 2 Jun 2023 00:30:14 +0300
> > > andy.shevchenko@...il.com wrote:
> > > > Thu, Jun 01, 2023 at 04:18:40PM -0400, Hugo Villeneuve kirjoitti:
> 
> ...
> 
> > > > Maybe positive one?
> > > >     if (mctrl_mask)
> > > >             regmap_update_bits(...);
> > >
> > > I used negative to save on indentation, but it also fits by converting it to positive, so done.
> 
> I understand, but in this case it is slightly more weird to have
> negative conditional and in either case return the value of the local
> variable.

Yes.

> > Greg did not yet respond to my email about the proposed tags, but if the new order of the patches and the stable tags I added seems ok to you, I will resend V7. It will then probably easier for Greg to comment directly on V7 for the stable tags (Cc:).
> 
> They look fine to me, but Greg is the maintainer, he decides if it's
> really okay or not.

Then I will submit V7 now.

Thank you,
Hugo.