linux-kernel - Re: [PATCH] highmem: Rename put_and_unmap_page() to unmap_and_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230602131801.GB628@quark.localdomain>
Date:   Fri, 2 Jun 2023 06:18:01 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Dave Chinner <dchinner@...hat.com>,
        Christian Brauner <brauner@...nel.org>,
        Chen Zhongjin <chenzhongjin@...wei.com>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Alexander Potapenko <glider@...gle.com>,
        Andrey Konovalov <andreyknvl@...il.com>,
        Bagas Sanjaya <bagasdotme@...il.com>,
        Jiaqi Yan <jiaqiyan@...gle.com>,
        Tony Luck <tony.luck@...el.com>,
        Peter Collingbourne <pcc@...gle.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH] highmem: Rename put_and_unmap_page() to
 unmap_and_put_page()

On Fri, Jun 02, 2023 at 12:33:07PM +0200, Fabio M. De Francesco wrote:
> With commit 849ad04cf562a ("new helper: put_and_unmap_page()"), Al Viro
> introduced the put_and_unmap_page() to use in those many places where we
> have a common pattern consisting of calls to kunmap_local() +
> put_page().
> 
> Obviously, first we unmap and then we put pages. Instead, the original
> name of this helper seems to imply that we first put and then unmap.
> 
> Therefore, rename the helper and change the only known upstreamed user
> (i.e., fs/sysv) before this helper enters common use and might become
> difficult to find all call sites and instead easy to break the builds.
> 
> Cc: Al Viro <viro@...iv.linux.org.uk>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>

Reviewed-by: Eric Biggers <ebiggers@...gle.com>

- Eric