linux-kernel - Re: [PATCH v8 1/1] gpio: add sloppy logic analyzer using polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHn3krVTwGp/0YhO@smile.fi.intel.com>
Date:   Fri, 2 Jun 2023 17:07:14 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org,
        Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v8 1/1] gpio: add sloppy logic analyzer using polling

On Fri, Jun 02, 2023 at 08:57:36AM +0200, Geert Uytterhoeven wrote:
> On Fri, Jun 2, 2023 at 8:51 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> > On Thu, Jun 1, 2023 at 11:40 PM <andy.shevchenko@...il.com> wrote:
> > > Tue, Mar 29, 2022 at 11:11:26AM +0200, Wolfram Sang kirjoitti:

...

> > > However, I haven't checked if it's pure theoretical issue with the current code
> > > base of debugfs or a potential problem. Easy fix is to check an error code and
> >
> > I think debugfs_create_dir() can only fail reasonably due to OOM.
> 
> Oops, you were talking about NULL, not an error code.
> I don't think that can ever happen.

That's looks correct, I don't see (looking briefly into the fs/debugfs) that
NULL is possible to be returned. Wondering, why the heck we (used to) have
a lot of IS_ERR_OR_NULL() checks.

> And if I did miss something, it would crash when dereferencing a NULL
> pointer in d_really_is_positive() (as called in start_creating())...

I don't see how, but I see a big comment on top of `if (!parent)`.

-- 
With Best Regards,
Andy Shevchenko