linux-kernel - Re: [PATCH] KVM: x86/mmu: Grab memslot for correct address space in NX recovery worker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <168574912392.1016815.8543067517884131468.b4-ty@google.com>
Date:   Fri,  2 Jun 2023 17:52:28 -0700
From:   Sean Christopherson <seanjc@...gle.com>
To:     Sean Christopherson <seanjc@...gle.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Fabio Coatti <fabio.coatti@...il.com>
Subject: Re: [PATCH] KVM: x86/mmu: Grab memslot for correct address space in
 NX recovery worker

On Thu, 01 Jun 2023 18:01:37 -0700, Sean Christopherson wrote:
> Factor in the address space (non-SMM vs. SMM) of the target shadow page
> when recovering potential NX huge pages, otherwise KVM will retrieve the
> wrong memslot when zapping shadow pages that were created for SMM.  The
> bug most visibly manifests as a WARN on the memslot being non-NULL, but
> the worst case scenario is that KVM could unaccount the shadow page
> without ensuring KVM won't install a huge page, i.e. if the non-SMM slot
> is being dirty logged, but the SMM slot is not.
> 
> [...]

Applied to kvm-x86 fixes, thanks!

[1/1] KVM: x86/mmu: Grab memslot for correct address space in NX recovery worker
      https://github.com/kvm-x86/linux/commit/817fa998362d

--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes