linux-kernel - Re: [PATCH] net: sched: wrap tc_skip_wrapper with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28802979-d237-1c9c-ad05-10aaa8f46b48@mojatatu.com>
Date:   Fri, 2 Jun 2023 22:07:17 -0300
From:   Pedro Tammela <pctammela@...atatu.com>
To:     Min-Hua Chen <minhuadotchen@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: sched: wrap tc_skip_wrapper with CONFIG_RETPOLINE

On 02/06/2023 20:52, Min-Hua Chen wrote:
> This patch fixes the following sparse warning:
> 
> net/sched/sch_api.c:2305:1: sparse: warning: symbol 'tc_skip_wrapper' was not declared. Should it be static?
> 
> No functional change intended.
> 
> Signed-off-by: Min-Hua Chen <minhuadotchen@...il.com>

LGTM,

Acked-by: Pedro Tammela <pctammela@...atatu.com>

> ---
>   net/sched/sch_api.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
> index 014209b1dd58..9ea51812b9cf 100644
> --- a/net/sched/sch_api.c
> +++ b/net/sched/sch_api.c
> @@ -2302,7 +2302,9 @@ static struct pernet_operations psched_net_ops = {
>   	.exit = psched_net_exit,
>   };
>   
> +#if IS_ENABLED(CONFIG_RETPOLINE)
>   DEFINE_STATIC_KEY_FALSE(tc_skip_wrapper);
> +#endif
>   
>   static int __init pktsched_init(void)
>   {