linux-kernel - Re: [PATCH v3 2/8] iio: adc: rockchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHunAIbK7-tIvsm1@surfacebook>
Date:   Sat, 3 Jun 2023 23:48:00 +0300
From:   andy.shevchenko@...il.com
To:     Shreeya Patel <shreeya.patel@...labora.com>
Cc:     jic23@...nel.org, lars@...afoo.de, heiko@...ech.de,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        sebastian.reichel@...labora.com, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        gustavo.padovan@...labora.com, kernel@...labora.com,
        serge.broslavsky@...labora.com, Simon Xue <xxm@...k-chips.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v3 2/8] iio: adc: rockchip_saradc: Add support for RK3588

Sun, Jun 04, 2023 at 12:23:34AM +0530, Shreeya Patel kirjoitti:
> From: Simon Xue <xxm@...k-chips.com>
> 
> Add new start and read functions to support rk3588 device.
> Also, add a device compatible string for the same.

...

> +/* v2 registers */
> +#define SARADC2_CONV_CON		0x0
> +#define SARADC_T_PD_SOC			0x4
> +#define SARADC_T_DAS_SOC		0xc

Can you use fixed-width values for all registers?

	0x000
	0x004
	0x00c

> +#define SARADC2_END_INT_EN		0x104
> +#define SARADC2_ST_CON			0x108
> +#define SARADC2_STATUS			0x10c
> +#define SARADC2_END_INT_ST		0x110
> +#define SARADC2_DATA_BASE		0x120

-- 
With Best Regards,
Andy Shevchenko