linux-kernel - Re: [PATCH net-next 0/2] Move KSZ9477 errata handling to PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f512a9409ff824595855de5ef41b83776791715.camel@calian.com>
Date:   Sat, 3 Jun 2023 00:13:15 +0000
From:   Robert Hancock <robert.hancock@...ian.com>
To:     "andrew@...n.ch" <andrew@...n.ch>
CC:     "olteanv@...il.com" <olteanv@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "woojung.huh@...rochip.com" <woojung.huh@...rochip.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "kuba@...nel.org" <kuba@...nel.org>
Subject: Re: [PATCH net-next 0/2] Move KSZ9477 errata handling to PHY driver

On Sat, 2023-06-03 at 02:04 +0200, Andrew Lunn wrote:
> On Fri, Jun 02, 2023 at 05:40:17PM -0600, Robert Hancock wrote:
> > Patches to move handling for KSZ9477 PHY errata register fixes from
> > the DSA switch driver into the corresponding PHY driver, for more
> > proper layering and ordering.
> 
> 
> Hi Robert
> 
> Is it an issue when it is performed twice, both in the PHY and the
> DSA
> driver? This could happen if somebody was doing a git bisect and
> landed in the middle of these two.
> 
>        Andrew

I don't think you'd really end up in a worse position than without
either patch, it would just be doing some redundant register writes.

-- 
Robert Hancock <robert.hancock@...ian.com>