linux-kernel - Re: [PATCH] cdx: Drop useless LIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48ecec64-5e9f-8081-753b-f2c6f188980c@wanadoo.fr>
Date:   Sun, 4 Jun 2023 12:05:27 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     unlisted-recipients:; (no To-header on input)
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] cdx: Drop useless LIST_HEAD


Le 04/06/2023 à 06:44, Christophe JAILLET a écrit :
> 'cleanup_list' is unused, so drop it.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>   drivers/cdx/controller/mcdi.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cdx/controller/mcdi.c b/drivers/cdx/controller/mcdi.c
> index a211a2ca762e..03e34f214aea 100644
> --- a/drivers/cdx/controller/mcdi.c
> +++ b/drivers/cdx/controller/mcdi.c
> @@ -611,7 +611,6 @@ void cdx_mcdi_process_cmd(struct cdx_mcdi *cdx, struct cdx_dword *outbuf, int le
>   {
>   	struct cdx_mcdi_iface *mcdi;
>   	struct cdx_mcdi_cmd *cmd;
> -	LIST_HEAD(cleanup_list);
>   	unsigned int respseq;
>   
>   	if (!len || !outbuf) {


NAK. Ouch!

Something went wrong in my compile-testing process for this one, sorry 
for the noise.


CJ