linux-kernel - Re: [patch 4/6] x86/smp: Cure kexec() vs. mwait_play

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHwCurlgWM+Q8wCC@a4bf019067fa.jf.intel.com>
Date:   Sat, 3 Jun 2023 20:19:22 -0700
From:   Ashok Raj <ashok.raj@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     LKML <linux-kernel@...r.kernel.org>, <x86@...nel.org>,
        Ashok Raj <ashok.raj@...ux.intel.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "Tony Luck" <tony.luck@...el.com>,
        Arjan van de Veen <arjan@...ux.intel.com>,
        "Peter Zijlstra" <peterz@...radead.org>,
        Eric Biederman <ebiederm@...ssion.com>,
        Ashok Raj <ashok.raj@...el.com>
Subject: Re: [patch 4/6] x86/smp: Cure kexec() vs. mwait_play_dead() breakage

On Sat, Jun 03, 2023 at 10:07:01PM +0200, Thomas Gleixner wrote:

[snip]

> Fixes: ea53069231f9 ("x86, hotplug: Use mwait to offline a processor, fix the legacy case")
> Reported-by: Ashok Raj <ashok.raj@...el.com>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> ---
>  arch/x86/include/asm/smp.h |    2 +
>  arch/x86/kernel/smp.c      |   21 +++++++---------
>  arch/x86/kernel/smpboot.c  |   59 +++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 71 insertions(+), 11 deletions(-)
> 
> --- a/arch/x86/include/asm/smp.h
> +++ b/arch/x86/include/asm/smp.h
> @@ -132,6 +132,8 @@ void wbinvd_on_cpu(int cpu);
>  int wbinvd_on_all_cpus(void);
>  void cond_wakeup_cpu0(void);
>  
> +void smp_kick_mwait_play_dead(void);
> +

This seems like its missing prototype for #else for !CONFIG_SMP

 #else /* !CONFIG_SMP */
+#define smp_kick_mwait_play_dead(void) { }

Sorry I missed noticing this