linux-kernel - Re: [PATCH] thermal: intel_powerclamp: Check for a possible array out of bounds access.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 4 Jun 2023 18:13:30 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Daniil Dulov <d.dulov@...ddin.ru>, Zhang Rui <rui.zhang@...el.com>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Chen Yu <yu.c.chen@...el.com>,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        lvc-project@...uxtesting.org
Subject: Re: [PATCH] thermal: intel_powerclamp: Check for a possible array out
 of bounds access.

Cc list trimmed.

On Fri, Jun 2, 2023 at 11:12 AM Daniil Dulov <d.dulov@...ddin.ru> wrote:
>
> ratio may be equal to MAX_TARGET_RATIO - 1 that will result in
> out of bound access.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: d6d71ee4a14a ("PM: Introduce Intel PowerClamp Driver")
> Signed-off-by: Daniil Dulov <d.dulov@...ddin.ru>
> ---
>  drivers/thermal/intel/intel_powerclamp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/intel_powerclamp.c b/drivers/thermal/intel/intel_powerclamp.c
> index fb04470d7d4b..9deaf2b8ccf6 100644
> --- a/drivers/thermal/intel/intel_powerclamp.c
> +++ b/drivers/thermal/intel/intel_powerclamp.c
> @@ -277,7 +277,8 @@ static unsigned int get_compensation(int ratio)
>                 comp = (cal_data[ratio].steady_comp +
>                         cal_data[ratio - 1].steady_comp +
>                         cal_data[ratio - 2].steady_comp) / 3;
> -       } else if (cal_data[ratio].confidence >= CONFIDENCE_OK &&
> +       } else if (ratio < MAX_TARGET_RATIO - 1 &&
> +               cal_data[ratio].confidence >= CONFIDENCE_OK &&
>                 cal_data[ratio - 1].confidence >= CONFIDENCE_OK &&
>                 cal_data[ratio + 1].confidence >= CONFIDENCE_OK) {
>                 comp = (cal_data[ratio].steady_comp +
> --

Rui, Srinivas, can you have a look at this, please?