linux-kernel - Re: [PATCH v1 09/43] clocksource: ep93xx: Add driver for Cirrus Logic EP93xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <e7960f41-3d72-4037-9f9c-ff43fedd10e2@app.fastmail.com>
Date:   Sun, 04 Jun 2023 21:33:52 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Andy Shevchenko" <andy.shevchenko@...il.com>
Cc:     "Nikita Shubin" <nikita.shubin@...uefel.me>,
        "Alexander Sverdlin" <alexander.sverdlin@...il.com>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        "Daniel Lezcano" <daniel.lezcano@...aro.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Michael Peters" <mpeters@...eddedts.com>,
        "Kris Bahnsen" <kris@...eddedts.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 09/43] clocksource: ep93xx: Add driver for Cirrus Logic EP93xx

On Sun, Jun 4, 2023, at 21:24, Andy Shevchenko wrote:
> On Sun, Jun 4, 2023 at 8:19 PM Arnd Bergmann <arnd@...db.de> wrote:
>> On Sat, Jun 3, 2023, at 22:06, andy.shevchenko@...il.com wrote:
>> > Thu, Jun 01, 2023 at 08:34:00AM +0300, Nikita Shubin kirjoitti:
>
>> As long as the platform selects it, this is the normal
>> way to add a clocksource driver.
>
> Shall we now require this format of COMPILE_TEST for all new code
> (which is selectable)?

It's somewhat subsystem specific. For irqchip and clocksource drivers,
I think it's already done this way, but these are the ones that expect
a platform Kconfig option to select the drivers, which is usually
not done for other subsystems.

If the driver is not selected by the platform, you usually have

config FOO
      tristate "description"
      depends on ${PLATFORM} || COMPILE_TEST
      default ${PLATFORM}

which makes it possible to still disable it, or (optionally)
hide the option by adding "if COMPILE_TEST && !${PLATFORM}"
which I personally find a little too complicated but is
appropriate for some drivers that are required for booting.

   Arnd