linux-kernel - Re: [PATCH v4] Add .editorconfig file for basic formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kDJA8e0b+Mo_sxLUXs70E-P2un8GM+XtADr7RpM4eaKA@mail.gmail.com>
Date:   Sun, 4 Jun 2023 22:49:00 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Mickaël Salaün <mic@...ikod.net>
Cc:     Íñigo Huguet <ihuguet@...hat.com>,
        ojeda@...nel.org, danny@...ag0n.dev, masahiroy@...nel.org,
        jgg@...dia.com, linux-kernel@...r.kernel.org, corbet@....net,
        joe@...ches.com, linux@...musvillemoes.dk, willy@...radead.org,
        mailhol.vincent@...adoo.fr
Subject: Re: [PATCH v4] Add .editorconfig file for basic formatting

On Fri, Jun 2, 2023 at 5:37 PM Mickaël Salaün <mic@...ikod.net> wrote:
>
> Looks good to me, thanks!
>
> Acked-by: Mickaël Salaün <mic@...ikod.net>
>
> It would be nice to have a script to check files and output a diff if
> they are not in line with this configuration. That could also be used to
> measure how many files are compliant with these rules, and add this
> stats in the commit message.

Agreed.

> For some reasons, maintainers may want to exclude some files from these
> constraints. It would be useful to add some documentation explaining how
> to do it.

I would suggest adding it directly as a comment on top of the
`.editorconfig` file itself. Or, at least, put there the link to the
official page (https://editorconfig.org), which mentions `unset`,
assuming that is the way to do so.

Íñigo, I would also suggest sending the patch to Andrew Morton.

Cheers,
Miguel