linux-kernel - Re: [PATCH v3] usb: gadget: uvc: clean up comments and styling in video

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 4 Jun 2023 10:55:04 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Avichal Rakesh <arakesh@...gle.com>, dan.scally@...asonboard.com,
        thinh.nguyen@...opsys.com, etalvala@...gle.com,
        jchowdhary@...gle.com, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v3] usb: gadget: uvc: clean up comments and styling in
 video_pump

Hi Greg,

On Sun, Jun 04, 2023 at 09:43:40AM +0200, Greg KH wrote:
> On Fri, Jun 02, 2023 at 03:04:55PM -0700, Avichal Rakesh wrote:
> > This patch elaborates on some of the edge cases handled by
> > video_pump around setting no_interrupt flag, and brings the
> > code style in line with rest of the file.
> 
> When you say "and" that usually means it should be a separate patch.
> 
> But I really don't see what coding style changes you made here, what was
> it?
> 
> I can't see any logical changes made here, am I missing them?  Or is
> this all just a style-cleanup patch?

It's all style cleanup (variable declaration ordering), typo fixes, and
naming and documentation improvement, yes. I reviewed Avichal's original
patch when coming back from holidays, neither of us realizing that you
had merged it already. He sent a v2 and got told to rebase it on top of
your tree.  That's what v3 is, just handling the review comments.

I generally ask for patches to be split with one change per patch, but
given the small changes bundled here, and the fact that all of this just
incorporates the review comments, I think it would be a bit overkill.

-- 
Regards,

Laurent Pinchart