linux-kernel - Re: [PATCH v2 7/9] ASoC: codecs: Add support for the generic IIO auxiliary devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230605192245.4132e0ae@bootlin.com>
Date:   Mon, 5 Jun 2023 19:22:45 +0200
From:   Herve Codina <herve.codina@...tlin.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 7/9] ASoC: codecs: Add support for the generic IIO
 auxiliary devices

Hi Jonathan,

On Sun, 28 May 2023 18:38:55 +0100
Jonathan Cameron <jic23@...nel.org> wrote:

> On Tue, 23 May 2023 17:12:21 +0200
> Herve Codina <herve.codina@...tlin.com> wrote:
> 
> > Industrial I/O devices can be present in the audio path.
> > These devices needs to be used as audio components in order to be fully
> > integrated in the audio path.
> > 
> > This support allows to consider these Industrial I/O devices as auxliary
> > audio devices and allows to control them using mixer controls.
> > 
> > Signed-off-by: Herve Codina <herve.codina@...tlin.com>
> > ---  
> 
> > diff --git a/sound/soc/codecs/audio-iio-aux.c b/sound/soc/codecs/audio-iio-aux.c
> > new file mode 100644
> > index 000000000000..21575c4b35fd
> > --- /dev/null
> > +++ b/sound/soc/codecs/audio-iio-aux.c
> > @@ -0,0 +1,302 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +//
> > +// audio-iio-aux.c  --  ALSA SoC glue to use IIO devices as audio components
> > +//
> > +// Copyright 2023 CS GROUP France
> > +//
> > +// Author: Herve Codina <herve.codina@...tlin.com>
> > +
> > +#include <linux/iio/consumer.h>
> > +#include <linux/module.h>  
> 
> #include <linux/mod_devicetable.h> ideally to pick up
> the of_device_id definition without bouncing through some non 
> obvious header path.

Right, <linux/module.h> will be replaced by <linux/mod_devicetable.h> in the
next iteration.

Thanks for the review,
Hervé

> 
> 
> > +#include <linux/slab.h>
> > +#include <sound/soc.h>
> > +#include <sound/tlv.h>  
> 
> Otherwise, the IIO elements of this look good.  So for those at least
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> 
> I don't have enough knowledge of the snd stuff to review those
> parts.
> 
> Jonathan
> 
>