linux-kernel - Re: [PATCH] libbpf:fix use empty function pointers in ringbuf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZH4a1l1pfG8ewo3v@google.com>
Date:   Mon, 5 Jun 2023 10:26:46 -0700
From:   Stanislav Fomichev <sdf@...gle.com>
To:     Xin Liu <liuxin350@...wei.com>
Cc:     daniel@...earbox.net, andrii@...nel.org, ast@...nel.org,
        bpf@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        hsinweih@....edu, jakub@...udflare.com, john.fastabend@...il.com,
        kuba@...nel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, pabeni@...hat.com,
        syzbot+49f6cef45247ff249498@...kaller.appspotmail.com,
        syzkaller-bugs@...glegroups.com, yanan@...wei.com,
        wuchangye@...wei.com, xiesongyang@...wei.com,
        kongweibin2@...wei.com, zhangmingyi5@...wei.com
Subject: Re: [PATCH] libbpf:fix use empty function pointers in ringbuf_poll

On 06/05, Xin Liu wrote:
> From: zhangmingyi <zhangmingyi5@...wei.com>
> 
> The sample_cb of the ring_buffer__new interface can transfer NULL. However,
> the system does not check whether sample_cb is NULL during 
> ring_buffer__poll, null pointer is used.

What is the point of calling ring_buffer__new with sample_cb == NULL?