linux-kernel - [tip:timers/core 19/21] kernel/time/posix-timers.c:385:46: error: 'TICK_NSECS' undeclared; did you mean 'TICK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202306060207.ZANMLerd-lkp@intel.com>
Date:   Tue, 6 Jun 2023 02:14:23 +0800
From:   kernel test robot <lkp@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        x86@...nel.org
Subject: [tip:timers/core 19/21] kernel/time/posix-timers.c:385:46: error:
 'TICK_NSECS' undeclared; did you mean 'TICK_NSEC'?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/core
head:   1263a2a9d71bac5ffabf9603c36e36cb6edbcdcf
commit: 63dede13d09850a8ace210f8e4227ac5a6b309ae [19/21] posix-timers: Clarify posix_timer_fn() comments
config: powerpc-allnoconfig (https://download.01.org/0day-ci/archive/20230606/202306060207.ZANMLerd-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=63dede13d09850a8ace210f8e4227ac5a6b309ae
        git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
        git fetch --no-tags tip timers/core
        git checkout 63dede13d09850a8ace210f8e4227ac5a6b309ae
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=powerpc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash kernel/time/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306060207.ZANMLerd-lkp@intel.com/

All errors (new ones prefixed by >>):

   kernel/time/posix-timers.c: In function 'posix_timer_fn':
>> kernel/time/posix-timers.c:385:46: error: 'TICK_NSECS' undeclared (first use in this function); did you mean 'TICK_NSEC'?
     385 |                                 ktime_t kj = TICK_NSECS;
         |                                              ^~~~~~~~~~
         |                                              TICK_NSEC
   kernel/time/posix-timers.c:385:46: note: each undeclared identifier is reported only once for each function it appears in


vim +385 kernel/time/posix-timers.c

   327	
   328	/*
   329	 * This function gets called when a POSIX.1b interval timer expires from
   330	 * the HRTIMER interrupt (soft interrupt on RT kernels).
   331	 *
   332	 * Handles CLOCK_REALTIME, CLOCK_MONOTONIC, CLOCK_BOOTTIME and CLOCK_TAI
   333	 * based timers.
   334	 */
   335	static enum hrtimer_restart posix_timer_fn(struct hrtimer *timer)
   336	{
   337		struct k_itimer *timr;
   338		unsigned long flags;
   339		int si_private = 0;
   340		enum hrtimer_restart ret = HRTIMER_NORESTART;
   341	
   342		timr = container_of(timer, struct k_itimer, it.real.timer);
   343		spin_lock_irqsave(&timr->it_lock, flags);
   344	
   345		timr->it_active = 0;
   346		if (timr->it_interval != 0)
   347			si_private = ++timr->it_requeue_pending;
   348	
   349		if (posix_timer_event(timr, si_private)) {
   350			/*
   351			 * The signal was not queued due to SIG_IGN. As a
   352			 * consequence the timer is not going to be rearmed from
   353			 * the signal delivery path. But as a real signal handler
   354			 * can be installed later the timer must be rearmed here.
   355			 */
   356			if (timr->it_interval != 0) {
   357				ktime_t now = hrtimer_cb_get_time(timer);
   358	
   359				/*
   360				 * FIXME: What we really want, is to stop this
   361				 * timer completely and restart it in case the
   362				 * SIG_IGN is removed. This is a non trivial
   363				 * change to the signal handling code.
   364				 *
   365				 * For now let timers with an interval less than a
   366				 * jiffie expire every jiffie and recheck for a
   367				 * valid signal handler.
   368				 *
   369				 * This avoids interrupt starvation in case of a
   370				 * very small interval, which would expire the
   371				 * timer immediately again.
   372				 *
   373				 * Moving now ahead of time by one jiffie tricks
   374				 * hrtimer_forward() to expire the timer later,
   375				 * while it still maintains the overrun accuracy
   376				 * for the price of a slight inconsistency in the
   377				 * timer_gettime() case. This is at least better
   378				 * than a timer storm.
   379				 *
   380				 * Only required when high resolution timers are
   381				 * enabled as the periodic tick based timers are
   382				 * automatically aligned to the next tick.
   383				 */
   384				if (IS_ENABLED(CONFIG_HIGHRES_TIMERS)) {
 > 385					ktime_t kj = TICK_NSECS;
   386	
   387					if (timr->it_interval < kj)
   388						now = ktime_add(now, kj);
   389				}
   390	
   391				timr->it_overrun += hrtimer_forward(timer, now, timr->it_interval);
   392				ret = HRTIMER_RESTART;
   393				++timr->it_requeue_pending;
   394				timr->it_active = 1;
   395			}
   396		}
   397	
   398		unlock_timer(timr, flags);
   399		return ret;
   400	}
   401	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki