linux-kernel - Re: [PATCH] block/rnbd: fix mixed module-builtin object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNATopDDvV+aVsa_qc6FCkT9v6mRQcABnrKMdW4oMkQfd1g@mail.gmail.com>
Date:   Mon, 5 Jun 2023 15:13:47 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Jinpu Wang <jinpu.wang@...os.com>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "Md. Haris Iqbal" <haris.iqbal@...os.com>,
        Nick Terrell <terrelln@...com>
Subject: Re: [PATCH] block/rnbd: fix mixed module-builtin object

On Mon, Jun 5, 2023 at 1:47 PM Jinpu Wang <jinpu.wang@...os.com> wrote:
>
> Hi Masahiro,
>
>
> On Sat, Jun 3, 2023 at 6:59 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
> >
> > With CONFIG_BLK_DEV_RNBD_CLIENT=m and CONFIG_BLK_DEV_RNBD_SERVER=y
> > (or vice versa), rnbd-common.o is linked to a module and also to
> > vmlinux even though CFLAGS are different between builtins and modules.
> >
> > This is the same situation as fixed by commit 637a642f5ca5 ("zstd:
> > Fixing mixed module-builtin objects").
> >
> > Turn rnbd_access_mode_str() into an inline function.
> Thx for you fix, but Guoqing has a slightly different patch in the queue:
>
> https://lore.kernel.org/linux-block/CAMGffEnDjAP3zqytmsYxacvUROLKZj+KhH6LOXicOoPhS9FJJQ@mail.gmail.com/
>

LGTM. Thank you.



-- 
Best Regards
Masahiro Yamada