linux-kernel - Re: [PATCH 08/12] arm64: dts: ti: k3-am64-evm: Fixup reference to phandles array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Jun 2023 15:50:18 -0500
From:   Nishanth Menon <nm@...com>
To:     "Kumar, Udit" <u-kumar1@...com>
CC:     Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Tero Kristo <kristo@...nel.org>,
        Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH 08/12] arm64: dts: ti: k3-am64-evm: Fixup reference to
 phandles array

On 22:32-20230605, Kumar, Udit wrote:
> Hi Nishanth
> 
> On 6/1/2023 8:56 PM, Nishanth Menon wrote:
> > When referring to array of phandles, using <> to separate the array
> > entries is better notation as it makes potential errors with phandle and
> > cell arguments easier to catch. Fix the outliers to be consistent with
> > the rest of the usage.
> > 
> > Signed-off-by: Nishanth Menon <nm@...com>
> > ---
> >   arch/arm64/boot/dts/ti/k3-am642-evm.dts | 12 ++++++------
> >   1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> > index 91bdc6026d1f..fef68a778ac9 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> > @@ -467,8 +467,8 @@ &usb0 {
> >   &cpsw3g {
> >   	pinctrl-names = "default";
> > -	pinctrl-0 = <&rgmii1_pins_default
> > -		     &rgmii2_pins_default>;
> > +	pinctrl-0 = <&rgmii1_pins_default>,
> > +		    <&rgmii2_pins_default>;
> 
> 
> Please see, if  pinctrl-0 can be defined in one line, instead of two, to be
> inline with most of changes in this series.

OK. I think i can respin it with that style change included once other
comments flow in.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D