[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZH5d1D_ci42zujmi@localhost.localdomain>
Date: Tue, 6 Jun 2023 00:12:36 +0200
From: Frederic Weisbecker <frederic@...nel.org>
To: Anna-Maria Behnsen <anna-maria@...utronix.de>
Cc: linux-kernel@...r.kernel.org,
Peter Zijlstra <peterz@...radead.org>,
John Stultz <jstultz@...gle.com>,
Thomas Gleixner <tglx@...utronix.de>,
Eric Dumazet <edumazet@...gle.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
Arjan van de Ven <arjan@...radead.org>,
"Paul E . McKenney" <paulmck@...nel.org>,
Frederic Weisbecker <fweisbec@...il.com>,
Rik van Riel <riel@...riel.com>,
Steven Rostedt <rostedt@...dmis.org>,
Sebastian Siewior <bigeasy@...utronix.de>,
Giovanni Gherdovich <ggherdovich@...e.cz>,
Lukasz Luba <lukasz.luba@....com>,
"Gautham R . Shenoy" <gautham.shenoy@....com>
Subject: Re: [PATCH v6 09/21] timer: add_timer_on(): Make sure TIMER_PINNED
flag is set
Le Wed, May 10, 2023 at 09:28:05AM +0200, Anna-Maria Behnsen a écrit :
> When adding a timer to the timer wheel using add_timer_on(), it is an
> implicitly pinned timer. With the timer pull at expiry time model in place,
> TIMER_PINNED flag is required to make sure timers end up in proper base.
>
> Add TIMER_PINNED flag unconditionally when add_timer_on() is executed.
>
> Signed-off-by: Anna-Maria Behnsen <anna-maria@...utronix.de>
The current users of add_timer_on() don't seem to play nasty
games. Those who use mixes of add_timer_on() and mod_timer()
at least have set TIMER_PINNED on setup time, so looks good.
Reviewed-by: Frederic Weisbecker <frederic@...nel.org>
Powered by blists - more mailing lists