linux-kernel - Re: [PATCH v3 0/3] lib/string_helpers et al.: Change return value of strreplace()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <168600428200.201645.8654517038188222559.b4-ty@chromium.org>
Date:   Mon,  5 Jun 2023 15:31:23 -0700
From:   Kees Cook <keescook@...omium.org>
To:     linux-kernel@...r.kernel.org, andriy.shevchenko@...ux.intel.com,
        gregkh@...uxfoundation.org, linux-ext4@...r.kernel.org,
        cezary.rojewski@...el.com
Cc:     Kees Cook <keescook@...omium.org>, tytso@....edu, jack@...e.com,
        andy@...nel.org, rafael@...nel.org
Subject: Re: [PATCH v3 0/3] lib/string_helpers et al.: Change return value of strreplace()

On Mon, 5 Jun 2023 20:05:50 +0300, Andy Shevchenko wrote:
> It's more convenient to have strreplace() to return the pointer to
>  the string itself. This will help users to make their code better.
> 
> The patch 1 kills the only user of the returned value of strreplace(),
> Patch 2 converts the return value of strreplace(). And patch 3 shows
> how it may be useful. That said, the series can be routed via fs tree,
> with or without the last patch.
> 
> [...]

Applied to for-next/hardening, thanks!

[1/3] jbd2: Avoid printing outside the boundary of the buffer
      https://git.kernel.org/kees/c/7afb6d8fa81f
[2/3] lib/string_helpers: Change returned value of the strreplace()
      https://git.kernel.org/kees/c/d01a77afd6be
[3/3] kobject: Use return value of strreplace()
      https://git.kernel.org/kees/c/b2f10148ec1e

-- 
Kees Cook