linux-kernel - Re: [PATCH v2] gpio: sifive: Add missing check for platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230605011710.52-1-jiasheng@iscas.ac.cn>
Date:   Mon,  5 Jun 2023 09:17:10 +0800
From:   Jiasheng Jiang <jiasheng@...as.ac.cn>
To:     andy.shevchenko@...il.com
Cc:     oe-kbuild-all@...ts.linux.dev, linus.walleij@...aro.org,
        brgl@...ev.pl, palmer@...belt.com, paul.walmsley@...ive.com,
        linux-gpio@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Jiasheng Jiang <jiasheng@...as.ac.cn>
Subject: Re: [PATCH v2] gpio: sifive: Add missing check for platform_get_irq

On Sun, 4 Jun 2023 04:59:46 +0800 Andy Shevchenko wrote:
>>    224          for (i = 0; i < ngpio; i++) {
>>    225                  chip->irq_number[i] = platform_get_irq(pdev, i);
>>  > 226                  if (chip->irq_number[i] < 0)
>>    227                          return chip->irq_number[i];
> 
> So, this should be
> 
>   ret = ...
>   if (ret < 0)
>     return ret;
>   irq_number = ret;
> 
>>    228          }

I will submit a v3 to fix it.
Also, the same goes for the other patch
"gpio: ath79: Add missing check for platform_get_irq".

Thanks,
Jiasheng