linux-kernel - Re: [PATCH v1] mtd: rawnand: meson: fix ready/busy command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230605101739.069b98af@xps-13>
Date:   Mon, 5 Jun 2023 10:17:39 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Arseniy Krasnov <avkrasnov@...rdevices.ru>
Cc:     <oxffffaa@...il.com>, <kernel@...rdevices.ru>,
        <stable@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-amlogic@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        Liang Yang <liang.yang@...ogic.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Kevin Hilman <khilman@...libre.com>,
        Jianxin Pan <jianxin.pan@...ogic.com>
Subject: Re: [PATCH v1] mtd: rawnand: meson: fix ready/busy command

Hi Arseniy,

avkrasnov@...rdevices.ru wrote on Mon, 5 Jun 2023 09:39:40 +0300:

> Hello Miquel!
> 
> I exclude this patch from the recent Meson patchset, as it is fix and not related to another patches.
> Also I think that I can split Meson patchset (from links below) in the following way:
> 1) Patch/patchset for OOB layout
> 2) Patchset for "nand-rb" logic (meson_nand.c + DT bindings)
> These two can also go independently:
> 3) https://lore.kernel.org/linux-mtd/20230601061850.3907800-6-AVKrasnov@sberdevices.ru/
> 4) https://lore.kernel.org/linux-mtd/20230601061850.3907800-7-AVKrasnov@sberdevices.ru/

LGTM.

> 
> What do You think?
> 
> Thanks, Arseniy
> 
> On 05.06.2023 09:10, Arseniy Krasnov wrote:
> > Fix the ready/busy command value.
> > 
> > Fixes: 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
> > Cc: stable@...r.kernel.org
> > Suggested-by: Liang Yang <liang.yang@...ogic.com>
> > Signed-off-by: Arseniy Krasnov <AVKrasnov@...rdevices.ru>
> > ---
> >  drivers/mtd/nand/raw/meson_nand.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> > index 074e14225c06..9dd4a676497b 100644
> > --- a/drivers/mtd/nand/raw/meson_nand.c
> > +++ b/drivers/mtd/nand/raw/meson_nand.c
> > @@ -37,7 +37,7 @@
> >  #define NFC_CMD_SCRAMBLER_ENABLE	BIT(19)
> >  #define NFC_CMD_SCRAMBLER_DISABLE	0
> >  #define NFC_CMD_SHORTMODE_DISABLE	0
> > -#define NFC_CMD_RB_INT		BIT(14)
> > +#define NFC_CMD_RB_INT		((0xb << 10) | BIT(18) | BIT(16))
> >  
> >  #define NFC_CMD_GET_SIZE(x)	(((x) >> 22) & GENMASK(4, 0))
> >    


Thanks,
Miquèl