linux-kernel - Re: [PATCH] x86/microcode/AMD: shrink the size of amd_ucode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230605082737.GAZH2cebuy4a4JPGhL@fat_crate.local>
Date:   Mon, 5 Jun 2023 10:27:37 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Zeng Heng <zengheng4@...wei.com>
Cc:     tglx@...utronix.de, dave.hansen@...ux.intel.com, hpa@...or.com,
        mingo@...hat.com, linux-kernel@...r.kernel.org,
        xiexiuqi@...wei.com, x86@...nel.org, liwei391@...wei.com
Subject: Re: [PATCH] x86/microcode/AMD: shrink the size of amd_ucode_patch
 array

On Mon, Jun 05, 2023 at 03:12:56PM +0800, Zeng Heng wrote:
> About the commit <7ff6edf4fef3>, the amd_ucode_patch is expanded as
> two-dimensional array. When CONFIG_MAXSMP is enabled or CONFIG_NODES_SHIFT
> is set as 10, this array would occupy memory up to 12M.

So?

That's a conscious user decision I presume.

> Here we allocate amd_ucode_patch array dynamically in need instead of
> static declaration.

Looks weird at a quick glance.

Anyway, I have a series which gets rid of those arrays altogether
- I just need to finish it.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette