linux-kernel - RE: [PATCH v4 2/3] dt-bindings: PCI: xilinx-xdma: Add YAML schemas for Xilinx XDMA PCIe Root Port Bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN7PR12MB72012A6CF6F4D9D10179D0E48B4DA@SN7PR12MB7201.namprd12.prod.outlook.com>
Date:   Mon, 5 Jun 2023 08:55:34 +0000
From:   "Havalige, Thippeswamy" <thippeswamy.havalige@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
CC:     "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "Gogada, Bharat Kumar" <bharat.kumar.gogada@....com>,
        "Simek, Michal" <michal.simek@....com>,
        "Yeleswarapu, Nagaradhesh" <nagaradhesh.yeleswarapu@....com>
Subject: RE: [PATCH v4 2/3] dt-bindings: PCI: xilinx-xdma: Add YAML schemas
 for Xilinx XDMA PCIe Root Port Bridge

Hi Krzysztof,

Regards,
Thippeswamy H

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Monday, June 5, 2023 1:09 PM
> To: Havalige, Thippeswamy <thippeswamy.havalige@....com>;
> bhelgaas@...gle.com; devicetree@...r.kernel.org; linux-
> pci@...r.kernel.org; linux-kernel@...r.kernel.org; robh+dt@...nel.org
> Cc: lorenzo.pieralisi@....com; linux-arm-kernel@...ts.infradead.org;
> Gogada, Bharat Kumar <bharat.kumar.gogada@....com>; Simek, Michal
> <michal.simek@....com>; Yeleswarapu, Nagaradhesh
> <nagaradhesh.yeleswarapu@....com>
> Subject: Re: [PATCH v4 2/3] dt-bindings: PCI: xilinx-xdma: Add YAML schemas
> for Xilinx XDMA PCIe Root Port Bridge
> 
> On 31/05/2023 10:38, Thippeswamy Havalige wrote:
> > Add YAML dtschemas of Xilinx XDMA Soft IP PCIe Root Port Bridge dt
> > binding.
> >
> > Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@....com>
> > Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@....com>
> > ---
> > change in v4:
> 
> 
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +        pcie@...00000 {
> > +            compatible = "xlnx,xdma-host-3.00";
> > +            reg = <0x0 0xa0000000 0x0 0x10000000>;
> > +            ranges = <0x2000000 0x0 0xB0000000 0x0 0xB0000000 0x0
> > + 0x1000000>,
> 
> If there is going to be resend, use lower-case hex everywhere.
> 
> Otherwise, it's fine:
-Agreed, ll update this in next patch.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Best regards,
> Krzysztof