linux-kernel - Re: [PATCH v3] gpio: ath79: Add missing check for platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcCMf9B6Cf6PTKSxbhv7_eYVNrG7CFNXi2nN-tJ2AjdNQ@mail.gmail.com>
Date:   Mon, 5 Jun 2023 12:20:56 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     oe-kbuild-all@...ts.linux.dev, linus.walleij@...aro.org,
        brgl@...ev.pl, palmer@...belt.com, paul.walmsley@...ive.com,
        linux-gpio@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] gpio: ath79: Add missing check for platform_get_irq

On Mon, Jun 5, 2023 at 4:53 AM Jiasheng Jiang <jiasheng@...as.ac.cn> wrote:
>
> Add the missing check for platform_get_irq() and return error
> if it fails.

Here it seems better, but still needs an explanation why returning an
error is not a problem (assuming DT might have a wrong number). I.o.w.
you need to prove that with current code this fails in that case
further. Otherwise you will need to prove that there may not be DT
with a wrong number.

-- 
With Best Regards,
Andy Shevchenko