linux-kernel - RE: [PATCH v2] cdx: Rename MCDI_LOGGING to CDX_MCDI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY4PR12MB1912E437FC6295F65141A0FB8F4DA@CY4PR12MB1912.namprd12.prod.outlook.com>
Date:   Mon, 5 Jun 2023 11:50:14 +0000
From:   "Gangurde, Abhijit" <abhijit.gangurde@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "Agarwal, Nikhil" <nikhil.agarwal@....com>,
        "Gupta, Nipun" <Nipun.Gupta@....com>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "git (AMD-Xilinx)" <git@....com>,
        "Simek, Michal" <michal.simek@....com>
Subject: RE: [PATCH v2] cdx: Rename MCDI_LOGGING to CDX_MCDI_LOGGING

[AMD Official Use Only - General]

>
>
> On Wed, May 24, 2023 at 11:46:13PM +0530, Abhijit Gangurde wrote:
> > MCDI_LOGGING is too generic considering other MCDI users
> > SFC_MCDI_LOGGING and SFC_SIENA_MCDI_LOGGING. Rename it to
> > CDX_MCDI_LOGGING makes it more domain specific.
> >
> > Also, Move CONFIG_CDX_MCDI_LOGGING to header file
> > and make logging variable as a configurable sysfs parameter.
>
> No, sorry, that is not allowed.  Just use the normal dynamic debugging
> in the kernel like everyone else uses.
>
> Also you didn't document your new sysfs file, which would have not
> allowed me to take this no matter what.

I'll drop the sysfs changes and send v3 patch for renaming of the macro
so it can be on the rc.
Also, will look onto it to be supported by dynamic debugging.

Thanks,
Abhijit