linux-kernel - Re: [PATCH] serial: st-asc: fix typo in property name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63e2c1bc-4a80-4857-899a-dd87d92c6f7e@foss.st.com>
Date:   Mon, 5 Jun 2023 14:08:49 +0200
From:   Patrice CHOTARD <patrice.chotard@...s.st.com>
To:     Raphael Gallais-Pou <rgallaispou@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: st-asc: fix typo in property name

Hi Raphael

On 6/4/23 10:35, Raphael Gallais-Pou wrote:
> Changes the property name read in the driver according to the YAML.
> According to device-tree documentation, property names should not
> include underscores.
> 
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@...il.com>
> ---
>  drivers/tty/serial/st-asc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
> index 5215e6910f68..6ef99a037a9b 100644
> --- a/drivers/tty/serial/st-asc.c
> +++ b/drivers/tty/serial/st-asc.c
> @@ -754,7 +754,7 @@ static struct asc_port *asc_of_get_asc_port(struct platform_device *pdev)
>  
>  	asc_ports[id].hw_flow_control = of_property_read_bool(np,
>  							"uart-has-rtscts");
> -	asc_ports[id].force_m1 =  of_property_read_bool(np, "st,force_m1");
> +	asc_ports[id].force_m1 =  of_property_read_bool(np, "st,force-m1");
>  	asc_ports[id].port.line = id;
>  	asc_ports[id].rts = NULL;
>  

Reviewed-by: Patrice Chotard <patrice.chotard@...s.st.com>

Thanks
Patrice