linux-kernel - Re: [PATCH v8 30/33] x86/fred: allow dynamic stack frame size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wn0i578t.ffs@tglx>
Date:   Mon, 05 Jun 2023 16:11:30 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Xin Li <xin3.li@...el.com>, linux-kernel@...r.kernel.org,
        x86@...nel.org, kvm@...r.kernel.org
Cc:     mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
        hpa@...or.com, peterz@...radead.org, andrew.cooper3@...rix.com,
        seanjc@...gle.com, pbonzini@...hat.com, ravi.v.shankar@...el.com,
        jiangshanlai@...il.com, shan.kang@...el.com
Subject: Re: [PATCH v8 30/33] x86/fred: allow dynamic stack frame size

On Mon, Apr 10 2023 at 01:14, Xin Li wrote:
> A FRED stack frame could contain different amount of information for
> different event types, or perhaps even for different instances of the
> same event type. Thus we need to eliminate the need of any advance
> information of the stack frame size to allow dynamic stack frame size.
>
> Implement it through:
>   1) add a new field user_pt_regs to thread_info, and initialize it
>      with a pointer to a virtual pt_regs structure at the top of a
>      thread stack.
>   2) save a pointer to the user-space pt_regs structure created by
>      fred_entrypoint_user() to user_pt_regs in fred_entry_from_user().
>   3) initialize the init_thread_info's user_pt_regs with a pointer to
>      a virtual pt_regs structure at the top of init stack.
>
> This approach also works for IDT, thus we unify the code.

And thereby remove the useful comment and replace it with an
undocumented macro mess.

I'm simply refusing to review this. It's not my job to understand this
undocumented hackery.

Thanks,

        tglx